Make border conditional in crumbs
ClosedPublic
Actions

Authored by chad on Jan 28 2015, 4:18 AM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP170dc15c05cb: Make border conditional in crumbs

Summary

Add a setBorder call to CrumbsView to be more deliberate when a border is drawn. Could not find any CSS hacks to set it conditionally CSS.

Test Plan

Browsed every application that called crumbs and make a design decision. Also fixed a few bad layouts.

Diff Detail

Repository

rP Phabricator

Branch

crumbies

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4104
Build 4117: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27748.Jan 28 2015, 4:18 AM

chad retitled this revision from to Make border conditional in crumbs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 28 2015, 4:18 AM

leafy

When does one setBorder(true) vs setBorder(false) ? Maybe its in the uiexample already?

This revision is now accepted and ready to land.Jan 28 2015, 4:57 AM

It's a pattern that I can't imagine can be made into a UIExample. Basically I want to not have a double horizontal rule that's taking up 98% of the top of the page width.

@epriestley did you have feedback? I think you said 98% on this.

I'd vaguely like to fix these pages (most/all of which seem unusual/inconsistent in some way) eventually, but am fine with this until we get around to that.

Closed by commit rP170dc15c05cb: Make border conditional in crumbs (authored by chad, committed by chad). · Explain WhyJan 28 2015, 5:33 PM

This revision was automatically updated to reflect the committed changes.