Fixes T7007. Using %B permits non-UTF8 data to be appended to Harbormaster build logs. Since we're not really in control of the processes Harbormaster is running remotely, and since they may output invalid UTF8 data, we should store the invalid data instead of failing the build (due to UTF8 exception).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7007: UTF8 exception occurring during Harbormaster build
- Commits
- Restricted Diffusion Commit
rP6e723c5c5aef: Use %B when writing to Harbormaster build logs
@epriestley said this was the right fix, though I haven't tested it on our production system which actually exhibits the issue yet.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- harbormaster-build-log
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4103 Build 4116: [Placeholder Plan] Wait for 30 Seconds