Differential D11530

Check to make sure credential is not null in SSH command interface
ClosedPublic
Actions

Authored by hach-que on Jan 28 2015, 1:09 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP82f506f175b1: Check to make sure credential is not null in SSH command interface

Summary

This adds a check to make sure the credential exists when loading it in the Drydock SSH interface. This effectively turns a fatal error (calling a method on a non-object) into a catchable exception.

Test Plan

Had a badly configured resource, saw the exception appear instead of daemon fataling.

Diff Detail

Repository

rP Phabricator

Branch

drydock-ssh-check-credential

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4101
Build 4114: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 27743.Jan 28 2015, 1:09 AM

hach-que retitled this revision from to Check to make sure credential is not null in SSH command interface.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2015, 1:09 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 28 2015, 7:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 28 2015, 7:12 PM

Closed by commit rP82f506f175b1: Check to make sure credential is not null in SSH command interface (authored by hach-que, committed by hach-que). · Explain WhyJan 28 2015, 11:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

interface/

command/

DrydockSSHCommandInterface.php

6 lines

Diff 27743

View Options

src/applications/drydock/interface/command/DrydockSSHCommandInterface.php

Check to make sure credential is not null in SSH command interfaceClosedPublicActions