Page MenuHomePhabricator
Differential D11527

Add FontIcons to PHUIObjectItemView
ClosedPublic
Actions

Authored by chad on Jan 27 2015, 7:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 4:59 PM
Unknown Object (File)
Mon, Nov 11, 4:59 PM
Unknown Object (File)
Thu, Nov 7, 9:24 PM
Unknown Object (File)
Fri, Nov 1, 9:28 AM
Unknown Object (File)
Fri, Nov 1, 6:24 AM
Unknown Object (File)
Tue, Oct 29, 2:30 PM
Unknown Object (File)
Tue, Oct 29, 2:30 PM
Unknown Object (File)
Tue, Oct 29, 11:07 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP155b83bb6e0e: Add FontIcons to PHUIObjectItemView
Summary

Added generic FontIcons for PHUIObjectItemView, used in Almanac Console. Simplified States.

Test Plan

Almanac Console, UIExamples

Diff Detail

Repository
rP Phabricator
Branch
PHUIObjectItemView-icons
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4091
Build 4104: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27716.Jan 27 2015, 7:24 PM
chad retitled this revision from to Add FontIcons to PHUIObjectItemView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 27 2015, 7:24 PM
chad updated this revision to Diff 27717.Jan 27 2015, 7:24 PM
chad edited the test plan for this revision. (Show Details)Jan 27 2015, 7:25 PM

Can't add an image, getting S3 errors.

epriestley accepted this revision.Jan 27 2015, 8:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2015, 8:24 PM
Closed by commit rP155b83bb6e0e: Add FontIcons to PHUIObjectItemView (authored by chad, committed by chad). · Explain WhyJan 27 2015, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
almanac/
controller/
12 lines
view/
phui/
25 lines
webroot/
rsrc/
css/
phui/
29 lines

Diff 27717

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility