Paths

Table of Contentst

Differential D11492

Add an AphrontHTTPProxyResponse
ClosedPublic
Actions

Authored by epriestley on Jan 25 2015, 3:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 15, 4:23 PM

	Unknown Object (File)
	Tue, Jan 14, 2:57 PM

	Unknown Object (File)
	Thu, Jan 9, 11:16 PM

	Unknown Object (File)
	Sat, Jan 4, 5:23 PM

	Unknown Object (File)
	Sat, Jan 4, 1:45 PM

	Unknown Object (File)
	Sat, Jan 4, 3:16 AM

	Unknown Object (File)
	Sat, Dec 28, 1:36 AM

	Unknown Object (File)
	Mon, Dec 23, 1:14 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7019: Proxy HTTP VCS traffic

Commits

Restricted Diffusion Commit
rP51b2c4d01eed: Add an AphrontHTTPProxyResponse

Summary

Ref T7019. Adds a new response which can proxy an HTTP request and pass the result through.

This is grossly inefficient for the same reasons as HTTP hosting is generally inefficient right now (T4369). This stuff is fixable but not trivial.

Test Plan

Replaced home page with a proxy to example.org, used Charles to view headers, saw the page headers and content proxy with an X-Phabricator-Proxied header.

Diff Detail

Repository

Branch

hproxy2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/aphront/response/AphrontHTTPProxyResponse.php:41	XHP16	TODO Comment
Advice	src/aphront/response/AphrontHTTPProxyResponse.php:51	XHP16	TODO Comment
Advice	src/aphront/response/AphrontHTTPProxyResponse.php:56	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 4036
Build 4049: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27641.Jan 25 2015, 3:19 PM

epriestley retitled this revision from to Add an AphrontHTTPProxyResponse.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7019: Proxy HTTP VCS traffic.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 25 2015, 3:19 PM

btrahan accepted this revision.Jan 27 2015, 10:14 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2015, 10:14 PM

Closed by commit rP51b2c4d01eed: Add an AphrontHTTPProxyResponse (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2015, 10:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

aphront/

response/

AphrontHTTPProxyResponse.php

65 lines

Diff 27641

src/__phutil_library_map__.php

Loading...

src/aphront/response/AphrontHTTPProxyResponse.php

Loading...