Differential D11483

Fix an issue with dragging the scrollbar handle from a noninitial position
ClosedPublic
Actions

Authored by epriestley on Jan 24 2015, 9:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 23, 10:35 PM

	Unknown Object (File)
	Thu, Jan 23, 10:35 PM

	Unknown Object (File)
	Thu, Jan 23, 10:35 PM

	Unknown Object (File)
	Tue, Jan 21, 3:40 PM

	Unknown Object (File)
	Tue, Jan 21, 1:02 PM

	Unknown Object (File)
	Fri, Jan 17, 5:08 PM

	Unknown Object (File)
	Tue, Dec 31, 4:16 AM

	Unknown Object (File)
	Dec 26 2024, 10:28 PM

Subscribers

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP25fc168c95e8: Fix an issue with dragging the scrollbar handle from a noninitial position

Summary

See <rPc40bc0c8bf75#4050>. Repro steps:

Scroll partway down the page.
Click and drag the scroll handle.

Prior to this diff, the handle incorrectly jumps back to the top of the page. This is because we didn't store the handle's original position. (In testing, I always dragged from near the top of the page, and I don't normally drag scrollbars, so I didn't notice this.)

Test Plan

Clicking and dragging a partially scrolled handle now works correctly.

Diff Detail

Repository

Branch

scrollx1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4023
Build 4036: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27624.Jan 24 2015, 9:58 PM

epriestley retitled this revision from to Fix an issue with dragging the scrollbar handle from a noninitial position.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 24 2015, 9:58 PM

epriestley mentioned this in rPc40bc0c8bf75: Replace the primary scrollbar with a fake one to prepare for a persistent….Jan 24 2015, 9:59 PM

shipitquick

This revision is now accepted and ready to land.Jan 24 2015, 10:00 PM

Closed by commit rP25fc168c95e8: Fix an issue with dragging the scrollbar handle from a noninitial position (authored by epriestley, committed by epriestley). · Explain WhyJan 24 2015, 10:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

16 lines

webroot/

rsrc/

externals/

javelin/

lib/

10 lines

Diff 27624

resources/celerity/map.php

Loading...

webroot/rsrc/externals/javelin/lib/Scrollbar.js

Loading...