Page MenuHomePhabricator
Differential D11480

Don't activate JX.Scrollbar if we don't need to
ClosedPublic
Actions

Authored by epriestley on Jan 24 2015, 2:18 AM.
Tags
None
Referenced Files
F14377354: D11480.diff
Sat, Dec 21, 1:28 AM
F14361337: D11480.id27620.diff
Fri, Dec 20, 11:14 AM
Unknown Object (File)
Sat, Dec 14, 2:48 PM
Unknown Object (File)
Fri, Dec 6, 6:23 PM
Unknown Object (File)
Thu, Nov 28, 6:57 PM
Unknown Object (File)
Wed, Nov 27, 6:07 PM
Unknown Object (File)
Fri, Nov 22, 11:04 PM
Unknown Object (File)
Nov 17 2024, 9:40 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP512b17361845: Don't activate JX.Scrollbar if we don't need to
Summary

See discussion on rPc40bc0c8bf75. Fixes a couple of glitchy things:

  • Things were generally not nice on iOS.
  • On OSX, with no mouse, the OS scrollbar and our fake scrollbar would both draw.
  • Bar z-index was not set quite correctly.

Specifically, check if we need these bars. If we don't, just exit immediately and use the OS bars.

Test Plan
  • Tested Safari, Firefox, Chrome with and without a mouse.
  • Tested iOS Simualtor.

Diff Detail

Repository
rP Phabricator
Branch
scrolltweak
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4020
Build 4033: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27619.Jan 24 2015, 2:18 AM
epriestley retitled this revision from to Don't activate JX.Scrollbar if we don't need to.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 24 2015, 2:18 AM
epriestley mentioned this in rPc40bc0c8bf75: Replace the primary scrollbar with a fake one to prepare for a persistent….Jan 24 2015, 2:18 AM
chad accepted this revision.Jan 24 2015, 2:22 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2015, 2:22 AM
Closed by commit rP512b17361845: Don't activate JX.Scrollbar if we don't need to (authored by epriestley, committed by epriestley). · Explain WhyJan 24 2015, 2:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
webroot/
rsrc/
css/
application/
base/
10 lines
core/
2 lines
externals/
javelin/
lib/
8 lines

Diff 27619

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Scrollbar.js

Loading...
Phabricator · Built by Phacility