Paths

Table of Contentst

Differential D11477

Remove 'initFromConduit' option from Diffusion
ClosedPublic
Actions

Authored by epriestley on Jan 23 2015, 2:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 12:30 PM

	Unknown Object (File)
	Fri, Dec 27, 12:44 AM

	Unknown Object (File)
	Thu, Dec 26, 4:26 AM

	Unknown Object (File)
	Sun, Dec 22, 1:47 PM

	Unknown Object (File)
	Fri, Dec 20, 4:01 AM

	Unknown Object (File)
	Wed, Dec 18, 1:24 AM

	Unknown Object (File)
	Tue, Dec 17, 10:01 AM

	Unknown Object (File)
	Thu, Dec 12, 10:09 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2783: Make working-copy operations service-oriented

Commits

Restricted Diffusion Commit
rP8d087ae738d8: Remove 'initFromConduit' option from Diffusion

Summary

Ref T2783. I think this served two purposes:

Improving performance in cases where we "know" a repository is local.
Preventing loops.

It is now obsolete:

After D11476, refs can almost always resolve on a fast path.
As T2783 moves forward, we can usually no longer know when a repository is local without actually looking it up -- almost everything is allowed to run anywhere.
The cluster behavior in D11475 now prevents loops.

Test Plan

grep, browsed around. This didn't really do much of anything anymore.

Diff Detail

Repository

Branch

cproxy4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4016
Build 4029: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27607.Jan 23 2015, 2:43 PM

epriestley retitled this revision from to Remove 'initFromConduit' option from Diffusion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2783: Make working-copy operations service-oriented.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 23 2015, 2:44 PM

btrahan accepted this revision.Jan 23 2015, 6:22 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 23 2015, 6:22 PM

Closed by commit rP8d087ae738d8: Remove 'initFromConduit' option from Diffusion (authored by epriestley, committed by epriestley). · Explain WhyJan 23 2015, 9:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

DiffusionLintSaveRunner.php

1 line

conduit/

DiffusionQueryConduitAPIMethod.php

1 line

request/

DiffusionRequest.php

25 lines

repository/

worker/

PhabricatorRepositoryCommitHeraldWorker.php

1 line

commitchangeparser/

PhabricatorOwnersPackagePathValidator.php

1 line

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

1 line

Diff 27607

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

Loading...

src/applications/diffusion/request/DiffusionRequest.php

Loading...

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...

src/applications/repository/worker/commitchangeparser/PhabricatorOwnersPackagePathValidator.php

Loading...

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...