Differential D11474

Move Conduit client construction logic into Repository
ClosedPublic
Actions

Authored by epriestley on Jan 23 2015, 12:07 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7020: Proxy Diffusion Conduit requests

Commits

Restricted Diffusion Commit
rP7c2474bef756: Move Conduit client construction logic into Repository

Summary

Ref T7020. I need this elsewhere, and it's relatively internal anyway.

Test Plan

Browsed around my local, cluster-configured install and saw everything working fine.

Diff Detail

Repository

rP Phabricator

Branch

cproxy1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4010
Build 4023: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27601.Jan 23 2015, 12:07 PM

epriestley retitled this revision from to Move Conduit client construction logic into Repository.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7020: Proxy Diffusion Conduit requests.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 23 2015, 12:07 PM

btrahan accepted this revision.Jan 23 2015, 6:19 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 23 2015, 6:19 PM

Closed by commit rP7c2474bef756: Move Conduit client construction logic into Repository (authored by epriestley, committed by epriestley). · Explain WhyJan 23 2015, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

query/

DiffusionQuery.php

104 lines

repository/

storage/

PhabricatorRepository.php

119 lines

Diff 27601

View Options

src/applications/diffusion/query/DiffusionQuery.php