Paths

Table of Contentst

Differential D11459

Allow `arc unit --everything` to work without a base commit
ClosedPublic
Actions

Authored by joshuaspence on Jan 21 2015, 9:06 AM.

Tags

None

Referenced Files

	F14079405: D11459.diff
	Fri, Nov 22, 8:03 AM

	F14078103: D11459.diff
	Fri, Nov 22, 2:09 AM

	Unknown Object (File)
	Mon, Nov 18, 12:16 PM

	Unknown Object (File)
	Thu, Nov 14, 2:17 AM

	Unknown Object (File)
	Sun, Nov 10, 1:18 PM

	Unknown Object (File)
	Sat, Nov 9, 8:47 AM

	Unknown Object (File)
	Wed, Nov 6, 12:50 PM

	Unknown Object (File)
	Oct 23 2024, 11:39 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rARC0b22838ccaa8: Allow `arc unit --everything` to work without a base commit

Summary

Fixes T2461. Similarly to arc lint --everything, arc unit --everything should work without a base commit.

Test Plan

Removed the .git/arc/default-relative-commit file and ran arc unit --everything.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3969
Build 3982: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27544.Jan 21 2015, 9:06 AM

joshuaspence retitled this revision from to Allow `arc unit --everything` to work without a base commit.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: Restricted Maniphest Task.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 21 2015, 9:06 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

This feels a little wasteful since engines may be able to avoid doing this work (e.g., Phutil engines can enumerate tests without scanning the disk for files) but we can deal with that when we, e.g., adjust APIs for .arcunit or whatever.

This revision is now accepted and ready to land.Jan 22 2015, 8:20 PM

Closed by commit rARC0b22838ccaa8: Allow `arc unit --everything` to work without a base commit (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistUnitWorkflow.php

6 lines

Diff 27544

src/workflow/ArcanistUnitWorkflow.php

Loading...