Add the logger earlier in the Aphlict startup process
ClosedPublic
Actions

Authored by joshuaspence on Jan 21 2015, 7:37 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP04ee853cecf4: Add the logger earlier in the Aphlict startup process

Summary

Add the logger as soon as possible so that the log file will contain errors if the ws module cannot be loaded.

Test Plan

Ran ./bin/aphlict debug without having the ws module installed. Saw errors in the logs.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3967
Build 3980: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27542.Jan 21 2015, 7:37 AM

joshuaspence retitled this revision from to Add the logger earlier in the Aphlict startup process.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 21 2015, 7:37 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 21 2015, 8:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2015, 8:27 PM

Closed by commit rP04ee853cecf4: Add the logger earlier in the Aphlict startup process (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 21 2015, 8:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

aphlict_server.js

10 lines

Diff 27542

View Options

support/aphlict/server/aphlict_server.js

Add the logger earlier in the Aphlict startup processClosedPublicActions