Use dot notation in some places
ClosedPublic
Actions

Authored by joshuaspence on Jan 20 2015, 10:17 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPdd81268a8e4f: Use dot notation in some places

Summary

Use x.y in favor of x['y'] in some JavaScript callsites. Note that there are a bunch of places where the latter is explicitly used to trick PhabricatorJavelinLinter.

Test Plan

arc lint

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3927
Build 3940: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27494.Jan 20 2015, 10:17 AM

joshuaspence retitled this revision from to Enable the `sub` option for JSHint.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 20 2015, 10:17 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence updated this object.Jan 22 2015, 7:23 AM

joshuaspence edited edge metadata.

joshuaspence updated this object.

Rebase

The JX.* stuff is supposedly evading symbol stuff, but if it's not firing you can just land this.

I think T1549 is the real fix for this kind of issue anyway (i.e., annotate explicitly with a comment), not "trick the static analyzer".

Maybe remove the comments about evading static analysis, though.

webroot/rsrc/externals/javelin/core/Event.js
226–227	My expectation is that this will mask a different lint error ("file does not declare dependency on JX.Stratcom, but uses symbol"). Not sure why that's not firing.
webroot/rsrc/externals/javelin/core/init.js
60–61	As above.
webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
85–87	These might be trying to "weak bind" to avoid a circular dependency.