Fixes T6959.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6959: Relax detection of variant daemon configuration
- Commits
- Restricted Diffusion Commit
rP923096efc80f: Config - add phd.variant-config to suppress "Daemon & Web config" error…
When I was ready to test the feature, the "Daemon & Web config" error already showed up, from having added phd.variant-config. I went meta and changed the value of phd.variant-config to have phd.variant-config. The config error disappeared. I then changed the conpherence setting about conpherence email prefix and the error showed up again. Removing the conpherence config setting made the error disappear once more.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T6959
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3855 Build 3867: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/infrastructure/env/PhabricatorEnv.php | ||
|---|---|---|
| 319 | This is some unrelated stuff I should maybe remove. I don't have base-uri or production-uri set in my config, so this code throws an exception with just getEvnConfig... (I hit these codepaths trying to make a link in the new phd.variant-config description) | |
| src/applications/config/option/PhabricatorPHDConfigOptions.php | ||
|---|---|---|
| 72 | This link won't be very useful if the issue doesn't exist, since it will just say "This setup issue has been resolved.". Not sure if it's helpful or not on the balance. | |
| src/infrastructure/env/PhabricatorEnv.php | ||
| 235–238 | (Unrelated, but I think this should just be sort()?) | |
| 319 | This is unexpected -- getEnvConfig() should not throw if these values are null, only if they aren't declared anywhere. Do you have a copy of the exception/trace? | |
| src/infrastructure/env/PhabricatorEnv.php | ||
|---|---|---|
| 319 | I get one of those new fangled purdy error pages without any trace in the logs. Is there something I should do to have the logging occur? In any case, I'll back these bits out for this diff, as it should be a separate diff anyway. | |
Comment Actions
address other feedback (remove the link and just say "Daemon & Web issue"; change ksort to sort and verify that is okay because "Daemon & Web" issue did not show up)