Page MenuHomePhabricator

Reproduction case for PhabricatorEnv::getURI
AbandonedPublic

Authored by btrahan on Jan 14 2015, 9:52 PM.
Tags
None
Referenced Files
F14049373: D11400.diff
Thu, Nov 14, 12:47 PM
F14034843: D11400.diff
Sun, Nov 10, 2:26 AM
F14021370: D11400.diff
Wed, Nov 6, 8:02 AM
F14012080: D11400.diff
Fri, Nov 1, 7:14 AM
F13963395: D11400.id27381.diff
Tue, Oct 15, 3:37 PM
Unknown Object (File)
Sep 22 2024, 2:55 AM
Unknown Object (File)
Sep 22 2024, 2:52 AM
Unknown Object (File)
Sep 22 2024, 2:51 AM
Subscribers

Details

Reviewers
epriestley
Summary

see D11399#106902 and ensuing discussion. In the "options" codepath I get a purdy exception page and no information about the exception. In the maniphest code path everything works fine.

Test Plan

meta

Diff Detail

Repository
rP Phabricator
Branch
phabenvbug
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3856
Build 3868: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Reproduction case for PhabricatorEnv::getURI.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.

Oh. The issue is that you're accessing the config before it gets defined, since you're calling it from within ConfigOptions.

Oh right duh. Expected, nothing to see here, move along dear sir. :D

We could maybe set a flag somewhere to catch this in a more obvious way, so you'd get an exception like "Call to PhabricatorEnv::getEnvConfig() before config options were defined; you can't access config this early in the startup process."