Page MenuHomePhabricator
Differential D11398

Minor tidying of Aphlict code
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2015, 9:01 PM.
Tags
None
Referenced Files
F14005912: D11398.diff
Sun, Oct 27, 9:50 PM
F13978860: D11398.id27374.diff
Sat, Oct 19, 1:23 AM
F13973170: D11398.diff
Thu, Oct 17, 11:30 PM
Unknown Object (File)
Oct 6 2024, 4:25 AM
Unknown Object (File)
Oct 6 2024, 4:19 AM
Unknown Object (File)
Oct 6 2024, 4:19 AM
Unknown Object (File)
Oct 6 2024, 3:17 AM
Unknown Object (File)
Sep 19 2024, 12:08 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by btrahan.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPf55647736a68: Minor tidying of Aphlict code
Summary

Just some housekeeping... mostly just removing some unused variables.

Test Plan

Checked that I was still about to receive notifications from /notification/status/.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3851
Build 3863: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27374.Jan 14 2015, 9:01 PM
joshuaspence retitled this revision from to Minor tidying of Aphlict code.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 9:01 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 14 2015, 9:04 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/js/application/aphlict/behavior-aphlict-status.js
32

both sigil and meta can be removed wholesale, I think

This revision is now accepted and ready to land.Jan 14 2015, 9:04 PM
Closed by commit rPf55647736a68: Minor tidying of Aphlict code (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 14 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.
btrahan awarded a token.Jan 14 2015, 9:10 PM
epriestley mentioned this in D11360: Multiplex AJAX calls.Jan 15 2015, 2:14 PM

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
js/
application/
aphlict/
23 lines
4 lines
12 lines
10 lines

Diff 27374

View Options

webroot/rsrc/js/application/aphlict/Aphlict.js

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-status.js

Loading...
Phabricator · Built by Phacility