Paths

Table of Contentst

Differential D11387

Automatically create the Aphlict log directory
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2015, 12:10 PM.

Tags

None

Referenced Files

	F14103182: D11387.diff
	Tue, Nov 26, 9:11 PM

	Unknown Object (File)
	Sat, Nov 23, 8:53 AM

	Unknown Object (File)
	Wed, Nov 20, 8:23 AM

	Unknown Object (File)
	Fri, Nov 15, 5:54 PM

	Unknown Object (File)
	Tue, Nov 12, 12:01 PM

	Unknown Object (File)
	Fri, Nov 8, 8:52 AM

	Unknown Object (File)
	Thu, Nov 7, 4:49 PM

	Unknown Object (File)
	Oct 21 2024, 11:59 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6944: Try to create the pid directory in Aphlict

Commits

Restricted Diffusion Commit
rP1f09e05c683c: Automatically create the Aphlict log directory

Summary

Fixes T6944. Attempt to automatically create the log directory for the Aphlict server. If the directory can't be created, throw a helpful exception.

Test Plan

Set notification.log to /var/log/aphlict/aphlict.log.
Ran ./bin/aphlict debug and saw an exception (because the user doesn't have permissions to create the /var/log/aphlict directory).
Ran sudo chmod 777 /var/log.
Ran ./bin/aphlict debug and saw the /var/log/aphlict directory created.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3837
Build 3849: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27347.Jan 14 2015, 12:10 PM

joshuaspence retitled this revision from to Automatically create the Aphlict log directory.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6944: Try to create the pid directory in Aphlict.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 12:10 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 14 2015, 2:01 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
42	Consider passing `$recursive = true`.

This revision is now accepted and ready to land.Jan 14 2015, 2:01 PM

joshuaspence added inline comments.Jan 14 2015, 7:54 PM

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
42	Yeah, I was considering this. I suppose that is reasonable.

Pass $recursive = true

Closed by commit rP1f09e05c683c: Automatically create the Aphlict log directory (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 14 2015, 7:55 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11397: Don't try to create the Aphlict log directory if it already exists.Jan 14 2015, 8:59 PM

joshuaspence mentioned this in rP487eb4e916d2: Don't try to create the Aphlict log directory if it already exists.Jan 15 2015, 7:00 AM

joshuaspence mentioned this in D11906: Create the Aphlict PID directory.Feb 28 2015, 2:52 AM

joshuaspence mentioned this in rP658175925931: Create the Aphlict PID directory.Feb 28 2015, 10:53 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

aphlict/

management/

PhabricatorAphlictManagementWorkflow.php

18 lines

Diff 27347

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...