Paths

Table of Contentst

Differential D11386

Lint against undefined magic symbols
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2015, 11:56 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5639: Detect the use of undefined magic constants

Commits

rARC7aa89ddf9620: Lint against undefined magic symbols

Summary

Fixes T5639. Allows the detection of undefined magic symbols, such as the use of __DIR__ in a codebase that targets < PHP 5.3.0.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3836
Build 3848: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27346.Jan 14 2015, 11:56 AM

joshuaspence retitled this revision from to Lint against undefined magic symbols.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5639: Detect the use of undefined magic constants.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 11:56 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 14 2015, 2:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2015, 2:00 PM

Closed by commit rARC7aa89ddf9620: Lint against undefined magic symbols (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 14 2015, 7:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

5 lines

__tests__/

xhpast/

php53-features.lint-test

2 lines

Diff 27346

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/php53-features.lint-test

Lint against undefined magic symbolsClosedPublicActions