Page MenuHomePhabricator

Allow daemons to be terminated in the absence of MySQL
ClosedPublic

Authored by joshuaspence on Jan 14 2015, 11:41 AM.
Tags
None
Referenced Files
F14036611: D11385.diff
Sun, Nov 10, 11:07 AM
F14021696: D11385.diff
Wed, Nov 6, 11:16 AM
F14012131: D11385.diff
Fri, Nov 1, 7:21 AM
F14006224: D11385.id27367.diff
Mon, Oct 28, 3:31 AM
F14001952: D11385.diff
Fri, Oct 25, 1:32 PM
Unknown Object (File)
Oct 13 2024, 8:29 AM
Unknown Object (File)
Oct 6 2024, 8:30 AM
Unknown Object (File)
Oct 6 2024, 8:30 AM
Subscribers

Details

Summary

Fixes T6842. Allow the daemons to always be terminated, even if MySQL is down. I was hoping to be able to optionally enable this behavior with the --force flag, but this seems messy.

Test Plan
> ./bin/phd start
Freeing active task leases...
Freed 1 task lease(s).
Preparing to launch daemons.
NOTE: Logs will appear in '/var/tmp/phd/log/daemons.log'.

Starting daemons as phd
Launching daemon "PhabricatorRepositoryPullLocalDaemon".
Starting daemons as phd
Launching daemon "PhabricatorGarbageCollectorDaemon".
Starting daemons as phd
Launching daemon "PhabricatorTaskmasterDaemon".
Done.

> service mysql stop
mysql stop/waiting

> ./bin/phd stop
Interrupting daemon 'PhabricatorRepositoryPullLocalDaemon' (4263)...
Interrupting daemon 'PhabricatorGarbageCollectorDaemon' (4271)...
Interrupting daemon 'PhabricatorTaskmasterDaemon' (4287)...
Daemon 4263 exited.
Daemon 4271 exited.
Daemon 4287 exited.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3835
Build 3847: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Allow daemons to be terminated in the absence of MySQL.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2015, 2:00 PM
This revision was automatically updated to reflect the committed changes.