Differential D11380

Policy - add destructible interface
ClosedPublic
Actions

Authored by btrahan on Jan 14 2015, 12:11 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T6957: Make PhabricatorPolicy implement PhabricatorDestructibleInterface

Commits

Restricted Diffusion Commit
rP38d216f0f1f5: Policy - add destructible interface

Summary

Fixes T6957. If / when a policy object is destroyed, access to an object that uses that policy object is denied.

Test Plan

looked around in the code to fail confident enough to write the summary above

Diff Detail

Repository

rP Phabricator

Branch

T6957

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3829
Build 3841: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27336.Jan 14 2015, 12:11 AM

btrahan added a task: T6957: Make PhabricatorPolicy implement PhabricatorDestructibleInterface.

btrahan retitled this revision from to Policy - add destructible interface.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 14 2015, 12:11 AM

epriestley accepted this revision.Jan 14 2015, 12:13 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2015, 12:13 AM

Closed by commit rP38d216f0f1f5: Policy - add destructible interface (authored by btrahan, committed by btrahan). · Explain WhyJan 14 2015, 12:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

storage/

PhabricatorPolicy.php

15 lines

Diff 27336

View Options

src/applications/policy/storage/PhabricatorPolicy.php

Policy - add destructible interfaceClosedPublicActions