Page MenuHomePhabricator
Differential D11339

Fix Aphlict logging
ClosedPublic
Actions

Authored by epriestley on Jan 12 2015, 2:44 AM.
Tags
None
Referenced Files
F13817064: D11339.diff
Thu, Sep 19, 10:04 PM
Unknown Object (File)
Mon, Sep 16, 11:15 PM
Unknown Object (File)
Fri, Sep 13, 1:11 AM
Unknown Object (File)
Sat, Aug 31, 5:55 PM
Unknown Object (File)
Thu, Aug 29, 9:32 AM
Unknown Object (File)
Wed, Aug 28, 10:38 AM
Unknown Object (File)
Tue, Aug 27, 10:15 PM
Unknown Object (File)
Tue, Aug 27, 4:26 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
joshuaspence
btrahan
Commits
Restricted Diffusion Commit
rP0d070c91dc8d: Fix Aphlict logging
Summary

Yeahhhhhhhh....

  • Open a "stream", not a "steam".
  • Make error easier for users to understand.
  • Write to the log in debug mode so the issue is more apparent.
Test Plan
  • Started server with bad permissions, got usable error message.
  • Started server with good permissions, got logfile.

Diff Detail

Repository
rP Phabricator
Branch
logfile
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3785
Build 3797: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27241.Jan 12 2015, 2:44 AM
joshuaspence retitled this revision from to Fix Aphlict logging.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2015, 2:44 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 12 2015, 3:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 3:43 PM
epriestley requested changes to this revision.Jan 12 2015, 3:44 PM
epriestley edited edge metadata.

uh pulled the trigger on that a little bit fast

This revision now requires changes to proceed.Jan 12 2015, 3:44 PM
epriestley commandeered this revision.Jan 12 2015, 3:55 PM
epriestley edited reviewers, added: joshuaspence; removed: epriestley.
epriestley updated this revision to Diff 27254.Jan 12 2015, 3:57 PM
epriestley added a reviewer: btrahan.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)

Seems like it was haunted.

epriestley removed a reviewer: Blessed Reviewers.Jan 12 2015, 3:58 PM
btrahan accepted this revision.Jan 12 2015, 4:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 4:15 PM
Closed by commit rP0d070c91dc8d: Fix Aphlict logging (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2015, 4:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
aphlict/
management/
4 lines
support/
aphlict/
server/
24 lines
lib/
2 lines

Diff 27254

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
View Options

support/aphlict/server/aphlict_server.js

Loading...
View Options

support/aphlict/server/lib/AphlictLog.js

Loading...
Phabricator · Built by Phacility