Moar test coverage.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCafc53ed32211: Add unit tests for `ArcanistChmodLinter`
arc unit
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- chmod-test
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3781 Build 3792: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
src/lint/linter/ArcanistChmodLinter.php | ||
---|---|---|
47 | I was considering whether to add an isExecutable() method to ArcanistLintEngine, but decided against it for no particular reason. It could be reasonable to add this method though. |
src/lint/linter/__tests__/ArcanistLinterTestCase.php | ||
---|---|---|
105 | Oh, one other thing I noticed is that Filesystem::changePermissions doesn't do any validation on $mode, which seems wrong to me given that PHP will do unexpected things if you pass a string to $mode (see http://php.net/manual/en/function.chmod.php#96086, for example). |