Page MenuHomePhabricator

Fix some CC handling in Maniphest
ClosedPublic

Authored by epriestley on Jan 11 2015, 11:56 PM.
Tags
None
Referenced Files
F14071391: D11336.id27234.diff
Wed, Nov 20, 5:21 PM
Unknown Object (File)
Fri, Oct 25, 4:16 AM
Unknown Object (File)
Tue, Oct 22, 11:25 PM
Unknown Object (File)
Oct 19 2024, 4:18 PM
Unknown Object (File)
Oct 17 2024, 5:43 PM
Unknown Object (File)
Oct 17 2024, 7:47 AM
Unknown Object (File)
Oct 9 2024, 1:26 PM
Unknown Object (File)
Oct 9 2024, 1:26 PM
Subscribers
Tokens
"Grey Medal" token, awarded by btrahan.

Details

Summary

Fixes T6932. Fixes some issues from D11303.

  • When claiming a task, if it was previously unassigned, we would try to CC null.
  • When claiming a task, if the current owner was already CC'd, the viewer would incorrectly be warned about all subscribers being CC'd.
Test Plan
  • Claimed an unclaimed task.
  • Claimed a task with owner CC'd.

Diff Detail

Repository
rP Phabricator
Branch
taskxaction
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3770
Build 3781: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix some CC handling in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
This revision is now accepted and ready to land.Jan 12 2015, 12:18 AM
This revision was automatically updated to reflect the committed changes.