Page MenuHomePhabricator
Differential D11336

Fix some CC handling in Maniphest
ClosedPublic
Actions

Authored by epriestley on Jan 11 2015, 11:56 PM.
Tags
None
Referenced Files
F14001113: D11336.diff
Fri, Oct 25, 4:16 AM
F13993522: D11336.id27235.diff
Tue, Oct 22, 11:25 PM
F13981404: D11336.id27234.diff
Oct 19 2024, 4:18 PM
F13972206: D11336.id27233.diff
Oct 17 2024, 5:43 PM
F13970455: D11336.id.diff
Oct 17 2024, 7:47 AM
Unknown Object (File)
Oct 9 2024, 1:26 PM
Unknown Object (File)
Oct 9 2024, 1:26 PM
Unknown Object (File)
Oct 9 2024, 1:26 PM
View All Files
Subscribers
epriestley
Tokens
"Grey Medal" token, awarded by btrahan.

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T6932: Unable to claim a Maniphest task
Commits
Restricted Diffusion Commit
rP5b3b9b7182ae: Fix some CC handling in Maniphest
Summary

Fixes T6932. Fixes some issues from D11303.

  • When claiming a task, if it was previously unassigned, we would try to CC null.
  • When claiming a task, if the current owner was already CC'd, the viewer would incorrectly be warned about all subscribers being CC'd.
Test Plan
  • Claimed an unclaimed task.
  • Claimed a task with owner CC'd.

Diff Detail

Repository
rP Phabricator
Branch
taskxaction
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/controller/ManiphestTransactionSaveController.php:135XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 3770
Build 3781: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27233.Jan 11 2015, 11:56 PM
epriestley retitled this revision from to Fix some CC handling in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 11 2015, 11:56 PM
epriestley updated this revision to Diff 27234.Jan 11 2015, 11:56 PM
  • Clean lint.
joshuaspence accepted this revision.Jan 12 2015, 12:17 AM
joshuaspence updated this object.
joshuaspence added a task: T6932: Unable to claim a Maniphest task.
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 12:18 AM
btrahan awarded a token.Jan 12 2015, 1:50 AM
Closed by commit rP5b3b9b7182ae: Fix some CC handling in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2015, 1:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
34 lines

Diff 27234

View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...
Phabricator · Built by Phacility