Page MenuHomePhabricator

Minor tidying of `ArcanistPhutilLibraryLinter`
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 8:16 PM.
Tags
None
Referenced Files
F15354410: D11330.diff
Tue, Mar 11, 3:50 AM
Unknown Object (File)
Feb 20 2025, 2:05 AM
Unknown Object (File)
Feb 8 2025, 1:02 AM
Unknown Object (File)
Feb 8 2025, 1:02 AM
Unknown Object (File)
Feb 8 2025, 1:02 AM
Unknown Object (File)
Feb 8 2025, 1:02 AM
Unknown Object (File)
Feb 4 2025, 1:49 AM
Unknown Object (File)
Jan 29 2025, 4:41 AM
Subscribers

Details

Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3763
Build 3774: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Minor tidying of `ArcanistPhutilLibraryLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistPhutilLibraryLinter.php
193–215

Consider pht()'ing the entire block in cases like this. In other languages, it may take more/fewer/different sentences to express an idea, which are easier to translate in a single large block.

This revision is now accepted and ready to land.Jan 11 2015, 8:23 PM
This revision was automatically updated to reflect the committed changes.