Paths

Table of Contentst

Differential D11330

Minor tidying of `ArcanistPhutilLibraryLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jan 11 2015, 8:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 8, 1:02 AM

	Unknown Object (File)
	Sat, Feb 8, 1:02 AM

	Unknown Object (File)
	Sat, Feb 8, 1:02 AM

	Unknown Object (File)
	Sat, Feb 8, 1:02 AM

	Unknown Object (File)
	Tue, Feb 4, 1:49 AM

	Unknown Object (File)
	Wed, Jan 29, 4:41 AM

	Unknown Object (File)
	Sun, Jan 26, 7:25 PM

	Unknown Object (File)
	Fri, Jan 24, 1:20 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC6694834f29d6: Minor tidying of `ArcanistPhutilLibraryLinter`

Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3763
Build 3774: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27223.Jan 11 2015, 8:16 PM

joshuaspence retitled this revision from to Minor tidying of `ArcanistPhutilLibraryLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2015, 8:16 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 11 2015, 8:23 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/ArcanistPhutilLibraryLinter.php
193–215	Consider `pht()`'ing the entire block in cases like this. In other languages, it may take more/fewer/different sentences to express an idea, which are easier to translate in a single large block.

This revision is now accepted and ready to land.Jan 11 2015, 8:23 PM

Closed by commit rARC6694834f29d6: Minor tidying of `ArcanistPhutilLibraryLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 11:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilLibraryLinter.php

112 lines

Diff 27223

src/lint/linter/ArcanistPhutilLibraryLinter.php

Loading...