Paths

Table of Contentst

Differential D11319

Fix a lint renderering issue
ClosedPublic
Actions

Authored by joshuaspence on Jan 11 2015, 9:02 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC564dab098964: Fix a lint renderering issue

Summary

Currently there is an issue when renderering linter messages with ArcanistConsoleLintRenderer if $message->getChar() returns 0 (i.e. the value is unset).

Test Plan

Before

After

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3746
Build 3757: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27188.Jan 11 2015, 9:02 AM

joshuaspence retitled this revision from to Fix a lint renderering issue.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2015, 9:02 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Minor whitespace change

epriestley accepted this revision.Jan 11 2015, 4:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2015, 4:57 PM

Closed by commit rARC564dab098964: Fix a lint renderering issue (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 11 2015, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

renderer/

ArcanistConsoleLintRenderer.php

4 lines

Diff 27188

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Fix a lint renderering issueClosedPublicActions