Paths

Table of Contentst

Differential D11312

Fix parsing of `puppet-lint --version`
ClosedPublic
Actions

Authored by joshuaspence on Jan 11 2015, 5:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 8, 1:00 AM

	Unknown Object (File)
	Sat, Feb 8, 1:00 AM

	Unknown Object (File)
	Sat, Feb 8, 1:00 AM

	Unknown Object (File)
	Sat, Feb 8, 1:00 AM

	Unknown Object (File)
	Fri, Feb 7, 2:07 AM

	Unknown Object (File)
	Wed, Jan 29, 5:26 AM

	Unknown Object (File)
	Thu, Jan 23, 9:14 PM

	Unknown Object (File)
	Thu, Jan 23, 9:14 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC14e5fbbd6bfd: Fix parsing of `puppet-lint --version`

Summary

This seems to be off, at least for puppet-lint versions greater than 1.0.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 3739
Build 3750: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	4,704 ms	ArcanistPuppetLintLinterTestCase::testLinter
	253 ms	ArcanistXMLLinterTestCase::testLinter
	465 ms	ArcanistCSSLintLinterTestCase::testLinter
	114 ms	ArcanistCSSLintLinterTestCase::testVersion
	200 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (2 Failed · 33 Passed · 12 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 27181.Jan 11 2015, 5:23 AM

joshuaspence retitled this revision from to Fix parsing of `puppet-lint --version`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2015, 5:23 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 11 2015, 5:37 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2015, 5:37 PM

Closed by commit rARC14e5fbbd6bfd: Fix parsing of `puppet-lint --version` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 11 2015, 7:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPuppetLintLinter.php

2 lines

Diff 27181

src/lint/linter/ArcanistPuppetLintLinter.php

Loading...