Page MenuHomePhabricator
Differential D11295

T6594, Logged out users should see "View Raw" in dropdown of timeline items
ClosedPublic
Actions

Authored by lpriestley on Jan 9 2015, 1:26 AM.
Tags
None
Referenced Files
F13230967: D11295.diff
Mon, May 20, 11:28 PM
F13226829: D11295.id27137.diff
Sun, May 19, 11:36 PM
F13225837: D11295.id27137.diff
Sun, May 19, 5:42 PM
F13210670: D11295.diff
Fri, May 17, 5:06 AM
F13194645: D11295.diff
Sun, May 12, 9:44 PM
F13177401: D11295.diff
Wed, May 8, 7:41 PM
Unknown Object (File)
Sat, May 4, 6:25 PM
Unknown Object (File)
Thu, May 2, 11:00 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6594: Logged-out users can not access "View Raw" in comment dropdown menus
Commits
Restricted Diffusion Commit
rP7a6f4ab75a1f: T6594, Logged out users should see "View Raw" in dropdown of timeline items
Summary

Fixes T6594, Logged out users should be able to "View Raw" comments in public objects.

Test Plan

Log out, open maniphest task with comments, open dropdown associated with comment, click "View Raw", should be able to see raw comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 27137.Jan 9 2015, 1:26 AM
lpriestley retitled this revision from to T6594, Logged out users should see "View Raw" in dropdown of timeline items.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T6594: Logged-out users can not access "View Raw" in comment dropdown menus.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 9 2015, 1:26 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 9 2015, 2:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2015, 2:47 PM
Closed by commit rP7a6f4ab75a1f: T6594, Logged out users should see "View Raw" in dropdown of timeline items (authored by lpriestley, committed by epriestley). · Explain WhyJan 9 2015, 2:47 PM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in T7232: View Raw on removed comments makes 400 bad request.Feb 11 2015, 10:14 PM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
controller/
4 lines
view/
2 lines
view/
phui/
13 lines

Diff 27143

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility