Page MenuHomePhabricator
Files F13230967

D11295.diff
No OneTemporary
Actions

D11295.diff
View Options

diff --git a/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php b/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php
--- a/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php
+++ b/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php
@@ -85,4 +85,8 @@
return id(new AphrontDialogResponse())->setDialog($dialog);
}
+ public function shouldAllowPublic() {
+ return true;
+ }
+
}
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
@@ -451,6 +451,8 @@
$event->setIsEdited(true);
}
+ $event->setIsNormalComment(true);
+
// If we have a place for quoted text to go and this is a quotable
// comment, pass the quote target ID to the event view.
if ($this->getQuoteTargetID()) {
diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php
--- a/src/view/phui/PHUITimelineEventView.php
+++ b/src/view/phui/PHUITimelineEventView.php
@@ -22,6 +22,7 @@
private $token;
private $tokenRemoved;
private $quoteTargetID;
+ private $isNormalComment;
private $quoteRef;
private $reallyMajorEvent;
@@ -43,6 +44,15 @@
return $this->quoteTargetID;
}
+ public function setIsNormalComment($is_normal_comment) {
+ $this->isNormalComment = $is_normal_comment;
+ return $this;
+ }
+
+ public function getIsNormalComment() {
+ return $this->isNormalComment;
+ }
+
public function setHideByDefault($hide_by_default) {
$this->hideByDefault = $hide_by_default;
return $this;
@@ -547,8 +557,9 @@
'uri' => '/transactions/quote/'.$xaction_phid.'/',
'ref' => $ref,
));
+ }
- // if there is something to quote then there is something to view raw
+ if ($this->getIsNormalComment()) {
$items[] = id(new PhabricatorActionView())
->setIcon('fa-cutlery')
->setHref('/transactions/raw/'.$xaction_phid.'/')

File Metadata

Mime Type
text/plain
Expires
Tue, May 21, 11:28 PM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6275809
Default Alt Text
D11295.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility