Page MenuHomePhabricator
Differential D11264

Simplify version parsing for `ArcanistPhpLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2015, 8:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 3:41 PM
Unknown Object (File)
Tue, Jan 21, 3:40 PM
Unknown Object (File)
Tue, Jan 21, 3:11 PM
Unknown Object (File)
Mon, Jan 20, 2:23 PM
Unknown Object (File)
Fri, Jan 17, 8:30 AM
Unknown Object (File)
Sun, Jan 12, 10:30 AM
Unknown Object (File)
Mon, Jan 6, 10:11 PM
Unknown Object (File)
Mon, Jan 6, 11:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter`
Summary

We can use php --run "echo phpversion();" to return a nice, compact representation of the PHP version.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3660
Build 3670: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27061.Jan 7 2015, 8:35 AM
joshuaspence retitled this revision from to Simplify version parsing for `ArcanistPhpLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 7 2015, 8:35 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 27063.Jan 7 2015, 8:37 AM
joshuaspence edited edge metadata.

Remove whitespace

epriestley accepted this revision.Jan 7 2015, 12:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2015, 12:53 PM
Closed by commit rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 7 2015, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
14 lines

Diff 27063

View Options

src/lint/linter/ArcanistPhpLinter.php

Loading...
Phabricator · Built by Phacility