Paths

Table of Contentst

Differential D11264

Simplify version parsing for `ArcanistPhpLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2015, 8:35 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter`

Summary

We can use php --run "echo phpversion();" to return a nice, compact representation of the PHP version.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3659
Build 3669: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27061.Jan 7 2015, 8:35 AM

joshuaspence retitled this revision from to Simplify version parsing for `ArcanistPhpLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 7 2015, 8:35 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Remove whitespace

epriestley accepted this revision.Jan 7 2015, 12:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 7 2015, 12:53 PM

Closed by commit rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 7 2015, 1:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhpLinter.php

13 lines

Diff 27061

View Options

src/lint/linter/ArcanistPhpLinter.php

Simplify version parsing for `ArcanistPhpLinter`ClosedPublicActions