Page MenuHomePhabricator
Differential D11230

Fixes T6637, "closing by commit" should update task status and specify responsible commit, but drop the artificial comment.
ClosedPublic
Actions

Authored by lpriestley on Jan 5 2015, 11:38 PM.
Tags
None
Referenced Files
F14007326: D11230.id26967.diff
Tue, Oct 29, 3:48 AM
F14002463: D11230.id26967.diff
Fri, Oct 25, 7:17 PM
F13997366: D11230.id26967.diff
Thu, Oct 24, 4:02 AM
F13994069: D11230.diff
Wed, Oct 23, 3:31 AM
F13990138: D11230.id26961.diff
Tue, Oct 22, 1:32 AM
F13990033: D11230.id26961.diff
Tue, Oct 22, 12:35 AM
F13988050: D11230.diff
Mon, Oct 21, 12:50 PM
F13987781: D11230.id.diff
Mon, Oct 21, 11:16 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6637: Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in transaction message.
Commits
Restricted Diffusion Commit
rP204ae221d270: Fixes T6637, "closing by commit" should update task status and specify…
Summary

When updating the status of a task via commit, transaction should show responsible commit and status update if it was changed.

Test Plan

Push a commit "Fixes Txx", transaction should include status update and commit number.

Diff Detail

Repository
rP Phabricator
Branch
maniphestcommitcomment
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3601
Build 3609: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 26961.Jan 5 2015, 11:38 PM
lpriestley retitled this revision from to Fixes T6637, "closing by commit" should update task status and specify responsible commit, but drop the artificial comment..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 5 2015, 11:38 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley added a task: T6637: Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in transaction message. .Jan 5 2015, 11:44 PM
epriestley requested changes to this revision.Jan 6 2015, 12:03 AM
epriestley edited edge metadata.

One thing we forgot about, see inline.

src/applications/maniphest/storage/ManiphestTransaction.php
643–669

Oh, we should also add commit-aware strings for these. You can see them in /feed/.

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
513–516

These are OK (and more standard) to leave as commitPHID -- they're similar to object properties.

This revision now requires changes to proceed.Jan 6 2015, 12:03 AM
lpriestley updated this revision to Diff 26965.Jan 6 2015, 12:11 AM
lpriestley edited edge metadata.

Updating syntax and adding more checks for a commit message

lpriestley updated this revision to Diff 26966.Jan 6 2015, 12:14 AM
lpriestley edited edge metadata.

Spelling errors

epriestley accepted this revision.Jan 6 2015, 12:21 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 12:21 AM
Closed by commit rP204ae221d270: Fixes T6637, "closing by commit" should update task status and specify… (authored by lpriestley, committed by epriestley). · Explain WhyJan 6 2015, 12:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
storage/
76 lines
repository/
worker/
commitmessageparser/
18 lines

Diff 26961

View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility