Page MenuHomePhabricator
Differential D11216

Fix an XHPAST bug
ClosedPublic
Actions

Authored by joshuaspence on Jan 5 2015, 1:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 5:27 AM
Unknown Object (File)
Sun, Nov 17, 8:07 PM
Unknown Object (File)
Wed, Nov 13, 11:36 PM
Unknown Object (File)
Tue, Nov 12, 7:39 AM
Unknown Object (File)
Sat, Nov 9, 9:58 PM
Unknown Object (File)
Sat, Nov 9, 9:10 PM
Unknown Object (File)
Wed, Nov 6, 2:06 PM
Unknown Object (File)
Mon, Nov 4, 8:06 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU994a138b6d12: Fix an XHPAST bug
Summary

Currently, XHPAST fails to correctly parse myfunc($var1, &$var2);.

Test Plan

Before

xhpast-before (768×1 px, 68 KB)

After

xhpast-after (768×1 px, 69 KB)

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3584
Build 3592: [Placeholder Plan] Wait for 30 Seconds

Revision Contents
Changeset List

PathSize
support/
xhpast/
2 lines
313 lines
6219 lines
29 lines
83 lines

Diff 26937

View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.hpp

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
Phabricator · Built by Phacility