Paths

Table of Contentst

Differential D11216

Fix an XHPAST bug
ClosedPublic
Actions

Authored by joshuaspence on Jan 5 2015, 1:36 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU994a138b6d12: Fix an XHPAST bug

Summary

Currently, XHPAST fails to correctly parse myfunc($var1, &$var2);.

Test Plan

Before

After

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3584
Build 3592: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26937.Jan 5 2015, 1:36 AM

joshuaspence retitled this revision from to Fix an XHPAST bug.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 5 2015, 1:36 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D10537: Add a linter rule to detect call-time pass-by-reference.Jan 5 2015, 1:38 AM

joshuaspence mentioned this in D10537: Add a linter rule to detect call-time pass-by-reference.Jan 5 2015, 1:39 AM

epriestley accepted this revision.Jan 5 2015, 7:14 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 5 2015, 7:14 PM

Closed by commit rPHU994a138b6d12: Fix an XHPAST bug (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 5 2015, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

xhpast/

2 lines

313 lines

6219 lines

29 lines

83 lines

Diff 26937

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.hpp

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/scanner.lex.hpp

View Options

support/xhpast/scanner.lex.cpp

Fix an XHPAST bugClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26937

support/xhpast/parser.y

support/xhpast/parser.yacc.hpp

support/xhpast/parser.yacc.cpp

support/xhpast/scanner.lex.hpp

support/xhpast/scanner.lex.cpp

Fix an XHPAST bug
ClosedPublic
Actions

Revision Contents
Changeset List