Add a linter rule to detect the use of blacklisted functions
ClosedPublic
Actions

Authored by joshuaspence on Oct 12 2014, 11:25 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCd477df00eb5b: Add a linter rule to detect the use of blacklisted functions

Summary

As mentioned in the Phabricator PHP coding standards, the eval function should be avoided. There is some good discussion on StackOverflow as well.

Having said that, instead of hardcoding eval(), I have generalised this enough to allow a set of "blacklisted" functions to be defined with xhpast.blacklisted.function in the .arclint file.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3573
Build 3581: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25654.Oct 12 2014, 11:25 AM

joshuaspence retitled this revision from to Add a linter rule to detect the use of `eval`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 12 2014, 11:25 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2808: Diff 25654.Oct 12 2014, 11:26 AM

bump

Maybe we should implement this as xhpast.function-blacklist or similar (like phutil-xhpast.deprecated.functions), which would take a map from function name to explanation? That would be more flexible, at least. Not sure if there are other functions anyone might want to blacklist, though.

Seems reasonable.

joshuaspence retitled this revision from Add a linter rule to detect the use of `eval` to Add a linter rule to detect the use of blacklisted functions.Jan 4 2015, 11:18 PM

joshuaspence updated this object.

joshuaspence edited edge metadata.