Page MenuHomePhabricator

Fix a duplicate `case` statement
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 8:03 AM.
Tags
None
Referenced Files
F15415749: D11194.id26909.diff
Thu, Mar 20, 7:43 AM
F15390147: D11194.id26909.diff
Sat, Mar 15, 5:57 AM
F15388860: D11194.id26867.diff
Sat, Mar 15, 4:32 AM
Unknown Object (File)
Mon, Mar 3, 12:06 AM
Unknown Object (File)
Fri, Feb 28, 7:21 PM
Unknown Object (File)
Feb 8 2025, 12:47 AM
Unknown Object (File)
Feb 8 2025, 12:47 AM
Unknown Object (File)
Feb 8 2025, 12:47 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4e7c10cec54f: Fix a duplicate `case` statement
Summary

This appears to be a typo, identified by ArcanistXHPASTLinter::LINT_DUPLICATE_SWITCH_CASE (see D11171).

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3546
Build 3554: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Remove a duplicate `case` statement.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Nice catch!

I think this should be TYPE_TRUST_EMAILS, though, not removed.

This revision now requires changes to proceed.Jan 4 2015, 4:35 PM
joshuaspence retitled this revision from Remove a duplicate `case` statement to Fix a duplicate `case` statement.Jan 4 2015, 8:41 PM
joshuaspence updated this object.
joshuaspence edited edge metadata.
joshuaspence edited edge metadata.

Change to TYPE_TRUST_EMAILS

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 9:18 PM
This revision was automatically updated to reflect the committed changes.