Make the `PhabricatorApplication::getName()` method abstract
ClosedPublic
Actions

Authored by joshuaspence on Jan 1 2015, 7:01 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP22ee37e8b528: Make the `PhabricatorApplication::getName()` method abstract

Summary

In D10027, the getName() method was added to PhabricatorApplication to allow applications to explicitly declare their names rather than relying on the name being inferred from the name of the PhabricatorApplication subclass. I feel that sufficient time has passed such that we can require applications to explicitly declare their names.

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3446
Build 3453: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26697.Jan 1 2015, 7:01 AM

joshuaspence retitled this revision from to Make `PhabricatorApplication::getName()` abstract.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 1 2015, 7:01 AM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence retitled this revision from Make `PhabricatorApplication::getName()` abstract to Make the `PhabricatorApplication::getName()` method abstract.Jan 1 2015, 12:02 PM

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

epriestley accepted this revision.Jan 1 2015, 2:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 1 2015, 2:31 PM

Closed by commit rP22ee37e8b528: Make the `PhabricatorApplication::getName()` method abstract (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 1 2015, 11:07 PM

This revision was automatically updated to reflect the committed changes.