Page MenuHomePhabricator

Remove some old code handling the absence of the `file.uploadhash` Conduit method
ClosedPublic

Authored by joshuaspence on Jan 1 2015, 6:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2025, 9:51 PM
Unknown Object (File)
Feb 3 2025, 5:13 AM
Unknown Object (File)
Feb 2 2025, 6:02 AM
Unknown Object (File)
Jan 29 2025, 3:02 AM
Unknown Object (File)
Dec 26 2024, 2:31 AM
Unknown Object (File)
Dec 15 2024, 3:31 PM
Unknown Object (File)
Nov 28 2024, 1:33 PM
Unknown Object (File)
Nov 24 2024, 10:53 AM
Subscribers

Details

Summary

The file.uploadhash method was added a long time ago (in D4899). It should be safe to assume that this method exists on most installs.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3445
Build 3452: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Remove some old code.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence retitled this revision from Remove some old code to Remove some old code handling the absence of the `file.uploadhash` Conduit method.Jan 1 2015, 11:58 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistDiffWorkflow.php
2538–2541

We recover anyway, so this should never do anythign bad.

This revision is now accepted and ready to land.Jan 1 2015, 2:31 PM
This revision was automatically updated to reflect the committed changes.