Page MenuHomePhabricator
Differential D11091

Default remarkup code blocks to plain text, not PHP
ClosedPublic
Actions

Authored by epriestley on Dec 30 2014, 6:23 PM.
Tags
None
Referenced Files
F13233118: D11091.diff
Tue, May 21, 1:42 AM
F13218621: D11091.id26709.diff
Sat, May 18, 12:52 PM
F13213617: D11091.diff
Fri, May 17, 7:56 AM
Unknown Object (File)
Tue, May 7, 7:37 AM
Unknown Object (File)
Fri, May 3, 7:02 AM
Unknown Object (File)
Apr 25 2024, 6:38 PM
Unknown Object (File)
Apr 25 2024, 1:24 AM
Unknown Object (File)
Apr 9 2024, 10:22 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6823: Remove default highlighting of source code as PHP?
Commits
rPHUf9ecfb447892: Default remarkup code blocks to plain text, not PHP
Summary

Ref T6823. If we have no language information for a block, render it without syntax highlighting instead of with PHP syntax highlighting.

Thinking is to try this, see who notices/complains, and then pursue more tailored defaults if they seem worthwhile.

Test Plan

Wrote a code block with text in it, saw no default highlighting.

Diff Detail

Repository
rPHU libphutil
Branch
defaulttext
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3396
Build 3403: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26622.Dec 30 2014, 6:23 PM
epriestley retitled this revision from to Default remarkup code blocks to plain text, not PHP.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6823: Remove default highlighting of source code as PHP?.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 30 2014, 6:23 PM
btrahan accepted this revision.Dec 30 2014, 7:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 7:16 PM
Closed by commit rPHUf9ecfb447892: Default remarkup code blocks to plain text, not PHP (authored by epriestley, committed by epriestley). · Explain WhyJan 1 2015, 3:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
8 lines
2 lines
6 lines
2 lines
remarkup/
blockrule/
2 lines

Diff 26622

View Options

src/markup/engine/__tests__/remarkup/backticks-whitespace.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/just-backticks.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/tick-block-multi.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/tick-block.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php

Loading...
Phabricator · Built by Phacility