Differential D11076

Remove unused Phame edge constants
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 11:39 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP6e6e159dd79d: Remove unused Phame edge constants

Summary

This is dead code.

Test Plan

These edge types don't actually seem to be used?

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3373
Build 3380: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26589.Dec 30 2014, 11:39 AM

joshuaspence retitled this revision from to Convert Phame edge types to modern `EdgeType` subclasses.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 11:39 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I think these may legitimately be unused.

An early version of Phame allowed a post to appear on multiple blogs, but we scrapped that to make the UI simpler since there wasn't a very strong use case for it (and we could always do some "crosspost this..." sort of thing if we wanted later).

Phame blogs also originally had blogger membership lists, but that was obsoleted by policies.

So we can probably just remove them wholesale? Sorry you did all that legwork!

joshuaspence retitled this revision from Convert Phame edge types to modern `EdgeType` subclasses to Remove unused Phame edge constants.Dec 30 2014, 11:44 AM

joshuaspence updated this object.

joshuaspence edited edge metadata.