Page MenuHomePhabricator
Differential D11064

Define JavaScript functions before they are used
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:14 AM.
Tags
None
Referenced Files
F13380177: D11064.id.diff
Sat, Jun 29, 12:03 PM
F13376381: D11064.diff
Sat, Jun 29, 2:43 AM
F13359533: D11064.diff
Tue, Jun 25, 9:50 AM
F13344706: D11064.diff
Fri, Jun 21, 8:31 AM
F13329814: D11064.diff
Mon, Jun 17, 1:30 AM
F13317387: D11064.diff
Thu, Jun 13, 9:22 AM
F13303121: D11064.diff
Sat, Jun 8, 6:20 AM
F13289852: D11064.diff
Tue, Jun 4, 1:48 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP558e1ee3b8d2: Define JavaScript functions before they are used
Summary

This should be a fairly minor change that silences a bunch of JSHint warnings.

Test Plan

arc lint showed less warnings.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3359
Build 3366: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26557.Dec 30 2014, 10:14 AM
joshuaspence retitled this revision from to Define JavaScript functions before they are used.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:14 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 10:53 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:53 AM
Closed by commit rP558e1ee3b8d2: Define JavaScript functions before they are used (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
128 lines
webroot/
rsrc/
js/
application/
countdown/
4 lines
maniphest/
6 lines
pholio/
6 lines
phortune/
4 lines
3 lines
3 lines
core/
3 lines

Diff 26557

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/countdown/timer.js

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-batch-editor.js

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
View Options

webroot/rsrc/js/application/phortune/behavior-balanced-payment-form.js

Loading...
View Options

webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js

Loading...
View Options

webroot/rsrc/js/application/phortune/behavior-test-payment-form.js

Loading...
View Options

webroot/rsrc/js/core/behavior-dark-console.js

Loading...
Phabricator · Built by Phacility