Fixes T6533 - actively prompt the user to install and enable pygments
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T6533: Add a setup warning for pygments not being installed/configured
- Commits
- Restricted Diffusion Commit
rP736857d1f62c: Setup check to install/enable pygments
uninstalled / disabled pygments and checked setup checks
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pygments
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3337 Build 3344: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Minor wordsmithing/etc.
| src/applications/config/check/PhabricatorSetupCheckPygment.php | ||
|---|---|---|
| 53–59 | Just pht() the whole string, including "\n"'s, e.g.: pht( "Blah blah.\n". "Blah blah blah."); As written, this will make the first sentence translatable to other languages but the last two untranslatable. | |
| 54–59 | Phabicator can only highlight some languages without Pygments, so maybe this would be clearer with a name like: Install Pygments to Improve Syntax Highlighting ...and a message like: Phabricator can highlight a few languages by default, but installing and enabling Pygments (a third-party highlighting tool) will add syntax highlighting for many more languages. For instructions on installing and enabling Pygments, see the `pygments.enabled` configuration option. (It doesn't have very good instructions right now, but I can fix that.) | |