Page MenuHomePhabricator
Differential D11028

Remove docs sprite, replace with FontAwesome
ClosedPublic
Actions

Authored by chad on Dec 20 2014, 9:57 PM.
Tags
None
Referenced Files
F13137335: D11028.diff
Thu, May 2, 6:23 PM
Unknown Object (File)
Thu, Apr 25, 1:29 AM
Unknown Object (File)
Fri, Apr 12, 8:27 PM
Unknown Object (File)
Thu, Apr 11, 9:00 AM
Unknown Object (File)
Sat, Apr 6, 3:40 AM
Unknown Object (File)
Thu, Apr 4, 3:38 AM
Unknown Object (File)
Mar 26 2024, 5:31 AM
Unknown Object (File)
Mar 24 2024, 12:41 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPb925f42c5525: Remove docs sprite, replace with FontAwesome
Summary

Removes the docs sprite in Conpherence with FontAwesome, adds additional icons. Unsure what happens if someone customized this config option.

Test Plan

Added images and files to a Conpherence, saw new icons.

Diff Detail

Repository
rP Phabricator
Branch
sprite-docs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3309
Build 3316: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26478.Dec 20 2014, 9:57 PM
chad retitled this revision from to Remove docs sprite, replace with FontAwesome.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 20 2014, 9:57 PM
epriestley accepted this revision.Dec 20 2014, 11:37 PM
epriestley edited edge metadata.

Doubt this saw much/any customization.

This revision is now accepted and ready to land.Dec 20 2014, 11:37 PM
Closed by commit rPb925f42c5525: Remove docs sprite, replace with FontAwesome (authored by chad, committed by chad). · Explain WhyDec 21 2014, 4:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
sprite/
docs_1x/
docs_2x/
manifest/
scripts/
celerity/
1 line
src/
applications/
celerity/
32 lines
conpherence/
view/
3 lines
files/
config/
47 lines
storage/
2 lines
webroot/
rsrc/
css/
application/
conpherence/
8 lines
image/

Diff 26478

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/docs_1x/audio.png

Loading...
View Options

resources/sprite/docs_1x/doc.png

Loading...
View Options

resources/sprite/docs_1x/file.png

Loading...
View Options

resources/sprite/docs_1x/image.png

Loading...
View Options

resources/sprite/docs_1x/movie.png

Loading...
View Options

resources/sprite/docs_1x/pdf.png

Loading...
View Options

resources/sprite/docs_1x/place.png

Loading...
View Options

resources/sprite/docs_1x/zip.png

Loading...
View Options

resources/sprite/docs_2x/audio.png

Loading...
View Options

resources/sprite/docs_2x/doc.png

Loading...
View Options

resources/sprite/docs_2x/file.png

Loading...
View Options

resources/sprite/docs_2x/image.png

Loading...
View Options

resources/sprite/docs_2x/movie.png

Loading...
View Options

resources/sprite/docs_2x/pdf.png

Loading...
View Options

resources/sprite/docs_2x/place.png

Loading...
View Options

resources/sprite/docs_2x/zip.png

Loading...
View Options

resources/sprite/manifest/docs.json

Loading...
View Options

scripts/celerity/generate_sprites.php

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceFileWidgetView.php

Loading...
View Options

src/applications/files/config/PhabricatorFilesConfigOptions.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/widget-pane.css

Loading...
View Options

webroot/rsrc/css/sprite-docs.css

Loading...
View Options

webroot/rsrc/image/sprite-docs-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-docs.png

Loading...
Phabricator · Built by Phacility