Fixes T6790. Turn the old method into "new" (old signature) and "newEphemeral". Deploy "newEphemeral" as many places as possible; basically places we are not in the Differential application *and* have no intentions of ever saving the diff. These callsites are also all places we are just trying to get some changesets at the end of the day.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer
- Commits
- Restricted Diffusion Commit
rP8ac73b2bf351: Differential - tighten up access of Differential data from other applications
set differential application policy to 'administrators only'. viewed a commit in diffusion and it worked without any errors! i'm just using my thinkin' noodle on the other code paths.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hhh
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3301 Build 3308: [Placeholder Plan] Wait for 30 Seconds