Differential D11020

Differential - tighten up access of Differential data from other applications
ClosedPublic
Actions

Authored by btrahan on Dec 19 2014, 10:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 6:26 PM

	Unknown Object (File)
	Sat, Dec 14, 11:52 AM

	Unknown Object (File)
	Wed, Dec 11, 5:09 PM

	Unknown Object (File)
	Sun, Dec 8, 7:41 AM

	Unknown Object (File)
	Sat, Dec 7, 6:33 AM

	Unknown Object (File)
	Wed, Dec 4, 9:20 AM

	Unknown Object (File)
	Sat, Nov 30, 7:25 AM

	Unknown Object (File)
	Fri, Nov 29, 11:17 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer

Commits

Restricted Diffusion Commit
rP8ac73b2bf351: Differential - tighten up access of Differential data from other applications

Summary

Fixes T6790. Turn the old method into "new" (old signature) and "newEphemeral". Deploy "newEphemeral" as many places as possible; basically places we are not in the Differential application *and* have no intentions of ever saving the diff. These callsites are also all places we are just trying to get some changesets at the end of the day.

Test Plan

set differential application policy to 'administrators only'. viewed a commit in diffusion and it worked without any errors! i'm just using my thinkin' noodle on the other code paths.

Diff Detail

Repository

Branch

hhh

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3301
Build 3308: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26463.Dec 19 2014, 10:46 PM

btrahan retitled this revision from to Differential - tighten up access of Differential data from other applications.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 19 2014, 10:46 PM

epriestley accepted this revision.Dec 19 2014, 10:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 19 2014, 10:50 PM

Closed by commit rP8ac73b2bf351: Differential - tighten up access of Differential data from other applications (authored by btrahan, committed by btrahan). · Explain WhyDec 19 2014, 10:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialDiff.php

14 lines

diffusion/

controller/

DiffusionChangeController.php

3 lines

DiffusionDiffController.php

3 lines

data/

DiffusionPathChange.php

3 lines

engine/

DiffusionCommitHookEngine.php

3 lines

herald/

adapter/

HeraldCommitAdapter.php

3 lines

infrastructure/

diff/

PhabricatorDifferenceEngine.php

3 lines

Diff 26463

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...

src/applications/diffusion/data/DiffusionPathChange.php

Loading...

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...

src/infrastructure/diff/PhabricatorDifferenceEngine.php

Loading...