Page MenuHomePhabricator

Transactions - change show all key from "~" to "@"
ClosedPublic

Authored by btrahan on Dec 12 2014, 7:21 PM.
Tags
None
Referenced Files
F15453296: D10983.diff
Sat, Mar 29, 10:45 AM
F15420895: D10983.id26370.diff
Fri, Mar 21, 6:47 PM
F15420343: D10983.id26368.diff
Fri, Mar 21, 1:12 PM
F15419742: D10983.id.diff
Fri, Mar 21, 8:34 AM
F15419462: D10983.id26367.diff
Fri, Mar 21, 6:15 AM
F15417949: D10983.diff
Thu, Mar 20, 7:40 PM
F15387012: D10983.id.diff
Mar 15 2025, 1:38 AM
F15386339: D10983.id26370.diff
Mar 15 2025, 12:24 AM
Subscribers

Details

Summary

(some) international keyboard layouts can not type "~" in a way as to trigger this so use "@" instead. Save the suggested "+" as that seems like it would be useful for some future "adding stuff" keyboard workflow. Pretty stoked to get this squared away as I am quite confident our unreleased product will now be a huge smashing success. Ref T6683.

Test Plan

made sure my choice was okay via https://en.wikipedia.org/wiki/Dead_key#Dead_keys_on_various_keyboard_layouts; used the "@" key to show all transactions

Diff Detail

Repository
rP Phabricator
Branch
T6683
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3247
Build 3253: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - change show all key from "~" to "@".
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2014, 7:23 PM
This revision was automatically updated to reflect the committed changes.