Page MenuHomePhabricator

Transactions - change show all key from "~" to "@"
ClosedPublic

Authored by btrahan on Dec 12 2014, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 5:15 PM
Unknown Object (File)
Fri, Nov 29, 7:01 PM
Unknown Object (File)
Thu, Nov 28, 4:29 AM
Unknown Object (File)
Sat, Nov 23, 4:40 PM
Unknown Object (File)
Fri, Nov 22, 9:51 AM
Unknown Object (File)
Nov 17 2024, 2:12 PM
Unknown Object (File)
Nov 17 2024, 2:12 PM
Unknown Object (File)
Nov 8 2024, 6:44 PM
Subscribers

Details

Summary

(some) international keyboard layouts can not type "~" in a way as to trigger this so use "@" instead. Save the suggested "+" as that seems like it would be useful for some future "adding stuff" keyboard workflow. Pretty stoked to get this squared away as I am quite confident our unreleased product will now be a huge smashing success. Ref T6683.

Test Plan

made sure my choice was okay via https://en.wikipedia.org/wiki/Dead_key#Dead_keys_on_various_keyboard_layouts; used the "@" key to show all transactions

Diff Detail

Repository
rP Phabricator
Branch
T6683
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3248
Build 3254: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - change show all key from "~" to "@".
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2014, 7:23 PM
This revision was automatically updated to reflect the committed changes.