Page MenuHomePhabricator
Differential D10953

Title/Description quering for Passphrase credential
ClosedPublic
Actions

Authored by lpriestley on Dec 9 2014, 11:44 PM.
Tags
None
Referenced Files
F13158998: D10953.diff
Sun, May 5, 10:37 PM
Unknown Object (File)
Thu, Apr 25, 2:45 AM
Unknown Object (File)
Thu, Apr 11, 10:00 AM
Unknown Object (File)
Wed, Apr 10, 11:11 PM
Unknown Object (File)
Mon, Apr 8, 9:41 AM
Unknown Object (File)
Apr 3 2024, 5:44 PM
Unknown Object (File)
Feb 3 2024, 5:38 PM
Unknown Object (File)
Feb 3 2024, 8:17 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6562: Title/Description querying for Passphrase
Commits
Restricted Diffusion Commit
rPedc4c219caa9: Title/Description quering for Passphrase credential
Summary

Fixes T6562, Title/Description querying for Passphrase

Test Plan

Open Passphrase, open advanced queries, enter a title and/or description. Search results should show credentials matching the search.

Diff Detail

Repository
rP Phabricator
Branch
searchpassphrasebyname
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3206
Build 3212: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 26303.Dec 9 2014, 11:44 PM
lpriestley retitled this revision from to Title/Description quering for Passphrase credential.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T6562: Title/Description querying for Passphrase.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 9 2014, 11:44 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 26304.Dec 10 2014, 12:04 AM
lpriestley edited edge metadata.

Dropping description search in passphrase advanced queries, adding global title/description search for passphrase credentials.

epriestley accepted this revision.Dec 10 2014, 12:22 AM
epriestley edited edge metadata.

Looks perfect.

This revision is now accepted and ready to land.Dec 10 2014, 12:22 AM
Closed by commit rPedc4c219caa9: Title/Description quering for Passphrase credential (authored by lpriestley, committed by epriestley). · Explain WhyDec 10 2014, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26304

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialQuery.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

Loading...
View Options

src/applications/passphrase/search/PassphraseSearchIndexer.php

Loading...
Phabricator · Built by Phacility