Differential D10951

Projects - fix missing subscriber handling code in the editor
ClosedPublic
Actions

Authored by btrahan on Dec 9 2014, 6:13 PM.

Tags

None

Referenced Files

	F13192321: D10951.diff
	Sun, May 12, 6:48 AM

	F13191813: D10951.id26299.diff
	Sun, May 12, 12:41 AM

	F13190343: D10951.id26298.diff
	Sat, May 11, 9:54 AM

	F13182638: D10951.id.diff
	Fri, May 10, 12:34 AM

	F13173929: D10951.diff
	Tue, May 7, 9:29 PM

	Unknown Object (File)
	Sat, May 4, 7:05 AM

	Unknown Object (File)
	Fri, May 3, 11:38 PM

	Unknown Object (File)
	Sat, Apr 27, 6:22 PM

Subscribers

Tokens

"Orange Medal" token, awarded by epriestley.

Details

Reviewers

Maniphest Tasks

T6719: Projects are missing an internal apply implementation for edge transactions

Commits

Restricted Diffusion Commit
rP5b59a81ab9b3: Projects - fix missing subscriber handling code in the editor

Summary

Fixes T6719. At some point, we added automagical subscriptions via @mentions, and these were failing in project descriptions from a lack of an implementation in the editor. Said "implementation" is to do nothing, but it needs to be there nonetheless.

Test Plan

updated a project mentioning someone in the description and it worked. also saw a 'subscriber added' transaction

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26298.Dec 9 2014, 6:13 PM

btrahan added a task: T6719: Projects are missing an internal apply implementation for edge transactions.

btrahan retitled this revision from to Projects - fix missing subscriber handling code in the editor.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 9 2014, 6:13 PM

epriestley accepted this revision.Dec 9 2014, 6:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2014, 6:13 PM

epriestley awarded a token.Dec 9 2014, 6:14 PM

Closed by commit rP5b59a81ab9b3: Projects - fix missing subscriber handling code in the editor (authored by btrahan, committed by btrahan). · Explain WhyDec 9 2014, 6:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

2 lines

Diff 26299

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...