Page MenuHomePhabricator

Set the status of DrydockResource to BROKEN instead of performing a hard-delete
AbandonedPublic

Authored by hach-que on Nov 18 2014, 11:45 PM.
Tags
None
Referenced Files
F15413835: D10871.diff
Wed, Mar 19, 9:36 PM
F15401561: D10871.id26108.diff
Mon, Mar 17, 6:17 PM
F15344042: D10871.diff
Mon, Mar 10, 2:33 AM
F15286214: D10871.id26109.diff
Tue, Mar 4, 7:09 PM
Unknown Object (File)
Thu, Feb 27, 4:46 AM
Unknown Object (File)
Sat, Feb 22, 9:51 AM
Unknown Object (File)
Feb 8 2025, 12:08 AM
Unknown Object (File)
Feb 8 2025, 12:08 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This sets the status of DrydockResource to BROKEN instead of performing a hard-delete. This ensures you can still view leases associated with builds and view leases in Drydock even if allocation fails.

Test Plan

Tested this with 5 leases waiting for the same resource, and having that resource fail allocation. Saw the expected result.

Diff Detail

Repository
rP Phabricator
Branch
drydock-no-delete
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3085
Build 3091: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Set the status of DrydockResource to BROKEN instead of performing a hard-delete.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.

Depends on a bunch of other code. These changes are probably better just merged into those other diffs.

This revision now requires changes to proceed.Aug 8 2015, 6:27 PM