Page MenuHomePhabricator
Differential D10871

Set the status of DrydockResource to BROKEN instead of performing a hard-delete
AbandonedPublic
Actions

Authored by hach-que on Nov 18 2014, 11:45 PM.
Tags
None
Referenced Files
F15423282: D10871.id26109.diff
Sat, Mar 22, 2:29 PM
F15421493: D10871.id26108.diff
Sat, Mar 22, 12:17 AM
F15421049: D10871.diff
Fri, Mar 21, 8:36 PM
F15418630: D10871.id.diff
Fri, Mar 21, 12:31 AM
F15413835: D10871.diff
Wed, Mar 19, 9:36 PM
F15401561: D10871.id26108.diff
Mon, Mar 17, 6:17 PM
F15344042: D10871.diff
Mon, Mar 10, 2:33 AM
F15286214: D10871.id26109.diff
Tue, Mar 4, 7:09 PM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This sets the status of DrydockResource to BROKEN instead of performing a hard-delete. This ensures you can still view leases associated with builds and view leases in Drydock even if allocation fails.

Test Plan

Tested this with 5 leases waiting for the same resource, and having that resource fail allocation. Saw the expected result.

Diff Detail

Repository
rP Phabricator
Branch
drydock-no-delete
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3085
Build 3091: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 26108.Nov 18 2014, 11:45 PM
hach-que retitled this revision from to Set the status of DrydockResource to BROKEN instead of performing a hard-delete.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2014, 11:45 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B3085: Diff 26108.Nov 18 2014, 11:45 PM
hach-que updated this revision to Diff 26109.Nov 19 2014, 12:10 AM
hach-que edited edge metadata.

Tested

Harbormaster completed remote builds in B3086: Diff 26109.Nov 19 2014, 12:11 AM
hach-que updated this object.Nov 19 2014, 12:12 AM
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.Nov 19 2014, 12:24 AM
joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:32 AM
epriestley requested changes to this revision.Aug 8 2015, 6:27 PM
epriestley edited edge metadata.

Depends on a bunch of other code. These changes are probably better just merged into those other diffs.

This revision now requires changes to proceed.Aug 8 2015, 6:27 PM
hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 10:08 AM
hach-que abandoned this revision.Aug 24 2015, 10:10 AM

Merged into D10304.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
worker/
3 lines

Diff 26108

View Options

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...
Phabricator · Built by Phacility