Differential D10857

Have HTML mails return to and cc lines
ClosedPublic
Actions

Authored by chad on Nov 15 2014, 5:06 AM.

Tags

None

Referenced Files

	F14088083: D10857.id26067.diff
	Sun, Nov 24, 1:21 AM

	F14088019: D10857.id26073.diff
	Sun, Nov 24, 12:59 AM

	Unknown Object (File)
	Oct 24 2024, 8:53 AM

	Unknown Object (File)
	Oct 23 2024, 7:10 AM

	Unknown Object (File)
	Oct 20 2024, 5:59 PM

	Unknown Object (File)
	Sep 18 2024, 2:21 PM

	Unknown Object (File)
	Sep 11 2024, 8:11 AM

	Unknown Object (File)
	Sep 11 2024, 8:11 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6525: HTML mail does not show To/CC footers

Commits

Restricted Diffusion Commit
rP1edcabe53909: Have HTML mails return to and cc lines

Summary

Fixes T6525, adds cc and tos to html emails

Test Plan

send html and plain emails, see new stuff

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 26066.Nov 15 2014, 5:06 AM

chad retitled this revision from to Have HTML mails return to and cc lines.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6525: HTML mail does not show To/CC footers.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 15 2014, 5:06 AM

Harbormaster completed remote builds in B3058: Diff 26066.Nov 15 2014, 5:07 AM

derp

Harbormaster completed remote builds in B3059: Diff 26067.Nov 15 2014, 5:08 AM

epriestley accepted this revision.Nov 15 2014, 11:32 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
213	This doesn't over-escape? I would have guessed you might need something like: $html_body .= hsprintf('%s', $this->getRecipients...) But if it works, we're good.

This revision is now accepted and ready to land.Nov 15 2014, 11:32 AM

It does work, but is it more correct the other way?

pasted_file (223×217 px, 23 KB)

It's a little more correct the other way (it will work with a wider range out of outputs from the method, for example).

Closed by commit rP1edcabe53909: Have HTML mails return to and cc lines (authored by chad, committed by chad). · Explain WhyNov 15 2014, 5:12 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T6576: HTML bodies are not passed to all emails.Nov 17 2014, 9:36 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

replyhandler/

PhabricatorMailReplyHandler.php

31 lines

Diff 26073

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...