Page MenuHomePhabricator
Differential D10855

Diffusion - add verifyGitOrigin check to git fetch operation
ClosedPublic
Actions

Authored by btrahan on Nov 15 2014, 1:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Mon, Dec 9, 1:57 AM
Unknown Object (File)
Nov 22 2024, 9:12 AM
Unknown Object (File)
Nov 8 2024, 9:28 PM
Unknown Object (File)
Oct 27 2024, 7:18 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4946: Git checks for missing origin in 1.7.1 happen too late in the update process
T5938: Unable to setup a clone of private git repo hosted on GitHub
Commits
Restricted Diffusion Commit
rPd2ea0bc5f0df: Diffusion - add verifyGitOrigin check to git fetch operation
Summary

Fixes T4946. Theoretically.

Test Plan

iiam

also unit tests.

also

cd /var/repo/X
git remote remove origin # simulates origin-missing clone under 1.7.1
cd /path/to/phabricator
./bin/repository pull X

and observed no errors

Diff Detail

Repository
rP Phabricator
Branch
T5938
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3056
Build 3062: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26062.Nov 15 2014, 1:21 AM
btrahan added tasks: T5938: Unable to setup a clone of private git repo hosted on GitHub, T4946: Git checks for missing origin in 1.7.1 happen too late in the update process.
btrahan retitled this revision from to Diffusion - add verifyGitOrigin check to git fetch operation.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 15 2014, 1:21 AM
btrahan edited the test plan for this revision. (Show Details)Nov 15 2014, 1:21 AM
Harbormaster completed remote builds in B3056: Diff 26062.Nov 15 2014, 1:21 AM
epriestley accepted this revision.Nov 15 2014, 1:23 AM
epriestley edited edge metadata.

You can probably test by running:

cd /var/repo/X
git remote remove origin # simulates origin-missing clone under 1.7.1
cd /path/to/phabricator
./bin/repository pull X
This revision is now accepted and ready to land.Nov 15 2014, 1:23 AM
btrahan edited the test plan for this revision. (Show Details)Nov 15 2014, 2:02 AM
btrahan edited edge metadata.
Closed by commit rPd2ea0bc5f0df: Diffusion - add verifyGitOrigin check to git fetch operation (authored by btrahan, committed by btrahan). · Explain WhyNov 15 2014, 2:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26062

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
Phabricator · Built by Phacility