Page MenuHomePhabricator
Differential D10854

Set up colspec for differential 1up
ClosedPublic
Actions

Authored by avivey on Nov 15 2014, 12:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 10:59 AM
Unknown Object (File)
Fri, Dec 20, 11:14 AM
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Thu, Dec 19, 1:45 PM
Unknown Object (File)
Sat, Dec 14, 6:57 PM
Unknown Object (File)
Sun, Dec 8, 10:45 PM
Unknown Object (File)
Wed, Dec 4, 5:04 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP00b245a56679: Set up colspec for differential 1up
Summary

This upgrades 1up view from "does not work" back to "barely works".

Test Plan

view diff, 1up and 2up.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3055
Build 3061: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 26060.Nov 15 2014, 12:56 AM
avivey retitled this revision from to Set up colspec for differential 1up.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: Blessed Reviewers.
Herald edited edge metadata. · View Herald TranscriptNov 15 2014, 12:56 AM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B3055: Diff 26060.Nov 15 2014, 12:57 AM
epriestley accepted this revision.Nov 15 2014, 12:58 AM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Nov 15 2014, 12:58 AM
Closed by commit rP00b245a56679: Set up colspec for differential 1up (authored by avivey, committed by epriestley). · Explain WhyNov 15 2014, 12:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26060

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility